Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use biome as formatter and linter #1726

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

watany-dev
Copy link
Contributor

While this undoubtedly leads to efficiency gains, it's worth discussing its adoption, as there may be room for debate. However, it's certain that the integration would speed up the workflow.

Author should do the followings, if applicable

  • Add tests
  • Run tests
  • yarn denoify to generate files for Deno

@watany-dev watany-dev changed the title chore: Integrating a formatter and linter into Biome can streamline the process of formatting and linting. chore: use biome as formatter and linter Nov 20, 2023
@watany-dev
Copy link
Contributor Author

Biome 1.4 is out and will be updated after this.

https://biomejs.dev/blog/biome-wins-prettier-challenge

@yusukebe
Copy link
Member

@watany-dev

I've never tried Biome yet, so I'll try it.

@yusukebe
Copy link
Member

Biome seems to be good! It's fast!

However, in my opinion, it might be too early to introduce it to our project. Many developers have already installed extensions for prettier and eslint, but that's not the case for biome. While the linter and formatter can work on CI, it's better if they also work in the users' local environments. To achieve this, users would need to have the biome extension installed, right?

@watany-dev
Copy link
Contributor Author

Thanks for checking!
You may be right in that sense. We can preset it to Devcontainer, for example, but the local environment of the developer is not limited to that. we'll think about it again when we have enough to change the share of formatter and linter.

@yusukebe
Copy link
Member

Okay!

@yusukebe yusukebe mentioned this pull request Jan 27, 2024
@CarlosZiegler
Copy link

Hello,
I like this discussion, I aggred what @yusukebe said but user will be add the extensions for prettier and eslint too or ? I am using biome in two projects, and for me is easy to manage both, only install biome, and enable extensions, dont need to care about conflict of my eslint and project eslint or something like that.
Another thing is the rules, of my side I think cover better as es-lint:
Link: https://biomejs.dev/linter/rules

  • Accessibility : Rules focused on preventing accessibility problems.
  • Complexity : Rules that focus on inspecting complex code that could be simplified.
  • Correctness : Rules that detect code that is guaranteed to be incorrect or useless.
  • Performance : Rules catching ways your code could be written to run faster, or generally be more efficient.
  • Security : Rules that detect potential security flaws.
  • Style : Rules enforcing a consistent and idiomatic way of writing your code.
  • Suspicious : Rules that detect code that is likely to be incorrect or useless.
  • Nursery : New rules that are still under development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants