-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disableSSG from hono/ssg is not work with HonoX #58
Comments
Maybe I should write this in https://github.com/honojs/hono ? |
Hi @berlysia. Thank you! I believe this is a regression due to the following change. However, I also believe that this problem is not due to the PR above, but rather to the "output of a page that returns a 404". P.S. |
In my another investigation says this issue's key line is here (by good old console debug): I don't know why currently. And what's even weirder is that it works when pure hono and |
Resolved by honojs/hono#2477 , thanks! |
What version of HonoX are you using?
0.1.1
What steps can reproduce the bug?
npx create hono@latest
, select"x-basic"
createRoute
and usedisableSSG
from"hono/ssg"
build.ts
that runs https://github.com/honojs/vite-plugins/blob/55e3abfb8017c7ee9606458da665e3f09e0d428f/packages/ssg/src/ssg.ts#L34-L50 , or use "@hono/vite-ssg"What is the expected behavior?
Not even a text file containing "SSG is disabled" is left behind, and nothing is generated from the
disableSSG
route.What do you see instead?
Text files that contains "SSG is disabled"
Additional information
This is runtime agnostic issue. Reproduced in Node v21.6.0, Bun 1.0.23, Deno 1.39.4The text was updated successfully, but these errors were encountered: