fix: nested islands ssr #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusukebe
reviewed
Apr 16, 2024
|
Hi @kosei28 ! Awesome! This may work great. I've left a comment and updated the test by myself. |
|
Hi @kosei28 Looks good! I'll merge it now. Thank you for your contribution! |
usualoma
added a commit
to usualoma/honox
that referenced
this pull request
Apr 29, 2024
This reverts commit 2a72655.
yusukebe
pushed a commit
that referenced
this pull request
May 3, 2024
) * Revert "fix: check it should add `insideIslandSuffix` or not (#153)" This reverts commit 0f62853. * Revert "fix: nested islands ssr (#151)" This reverts commit 2a72655. * chore(deps): add dependency on jsonc-parser * fix(jsx): fix nested islands output by using honox/vite/components * test: add test for nested islands output * test: add alias for testing * refactor: tweak jsxImportSource normalization timing * test: add test for nested island components output * feat: Enable to specify the React API import source * test: add prettier-ignore to test cases * test: replace component path backslashes with forward slashes * refactor: refactor directory structure for honox-island component * test: update test config * refactor: oops, we should use vite instead of site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #150
With this change, nested islands will behave as one island.
New HTML:
