Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make hoodie.id() a hoodie.id getter #11

Closed
gr2m opened this issue Nov 19, 2015 · 0 comments
Closed

make hoodie.id() a hoodie.id getter #11

gr2m opened this issue Nov 19, 2015 · 0 comments
Labels
starter Type: Bug

Comments

@gr2m
Copy link
Member

gr2m commented Nov 19, 2015

Instead of

var id = hoodie.id()

we want

var id = hoodie.id

using a getter
nathanstilwell added a commit that referenced this issue Nov 21, 2015
@nathanstilwell
feat: Converting hoodie.id() to hoodie.id getter
b315a40 
BREAKING CHANGE: hoodie.id() was a method to return the id, but we are
converting it to a getter (see: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/get)

fixes #11
@nathanstilwell nathanstilwell mentioned this issue Nov 21, 2015
Merged
@gr2m gr2m closed this as completed in #16 Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
starter Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gr2m