feat: Add missing source verifications #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna note that there’s an existing bug in production on the dashboard where the following source verifications are not working:
They require 2 params, “webhook secret key” and “url”, but on the dashboard there’s only 1 input for the signing secret. Because I don’t fully know what the URL value is supposed to be, my PR is mimicking the dashboard which only ask for “webhook secret key”. Because of that, when trying to use one of those source verification we will run into an error as well. Can you share more how I should go about this?
Here's the error message when trying to use Favro source verification, just for reference