Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of go-github #157

Merged
merged 1 commit into from Oct 13, 2017
Merged

Conversation

lkysow
Copy link
Collaborator

@lkysow lkysow commented Oct 9, 2017

Now that google/go-github#693 is merged, we can use the go-github code to validate webhook requests that use secrets.

We still need to parse the request ourselves if they're not using secrets since the go-github library doesn't have that capability.

@codecov-io
Copy link

Codecov Report

Merging #157 into master will increase coverage by 0.63%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #157      +/-   ##
==========================================
+ Coverage   43.61%   44.24%   +0.63%     
==========================================
  Files          16       16              
  Lines        1261     1243      -18     
==========================================
  Hits          550      550              
+ Misses        690      672      -18     
  Partials       21       21
Impacted Files Coverage Δ
server/server.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6abe46c...1ae03d2. Read the comment docs.

@anubhavmishra anubhavmishra merged commit c777ba3 into master Oct 13, 2017
@anubhavmishra anubhavmishra deleted the latest-go-github branch October 13, 2017 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants