This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Dependencies, go version update, and Makefile fixes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the deps target was added in November 2020, it became the default make target. When make was called without arguments, it would install stuffbin and exit without building hopp-cli. Added an 'all' target as the default target that installs stuffbin and builds hopp-cli. Cleaned up all of the targets. Changed the deps target to use the idiomatic 'go install' instead of 'go get' to prevent mangling go.mod when installing stuffbin. Removed the 'update' target as it's redundant re: git pull.
it still mentioned the old pwcli repo. also updated cli.go 'methods' import statement to reflect this.
ioutil is deprecated. ioutil.ReadAll() is deprecated in favor of io.ReadAll() ioutil.ReadFile() is deprecated in favor of os.ReadFile()
|
Possibly we'll need to remove the stuffbin deps since go 16x introduced the same functionality in the stdlib. Will push an update as soon as possible. |
|
A lot of stuff needs to be fixed 😅 . Will push some of the patches in time |
|
@gbmor this is good to merge right? I'm planning to merge this as soon as I get a response |
|
@athul added conditional to only install stuffbin if it's not already installed on 'make' or 'make deps' or 'make all', merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these changes are related to either dependency updates, the go version update
1.13 -> 1.16, or the Makefile (and some of the Makefile changes are related to the go version update).Updated the dependencies since they were several versions behind.
Makefilewas no longer functioning as intended. The default target had been changed todeps, so it would installstuffbinand exit. I addedallas the default target to call bothdepsandbuild, and fixed the build line inbuild(it wasn't building anything). I also fixed thedepstarget to installstuffbinwithout manglinggo.mod(gonow lets you usego install url/to/repo@latestto do this). Then cleaned up the remaining targets, so theMakefileis working 100% again.go.modstill referred to the old repository, so I updated it to have the new path atgithub.com/hoppscotch/hopp-cliand bumped the minimum go version to1.16.Note: The install script linked in
README.mdstill referencespwcliso it needs to be updated, but it doesn't live in this repo so I can't update it.Removed references to deprecated standard library package
ioutilin favor ofio.ReadAllandos.ReadFile.Replaced string interpolation with wrapping when bubbling up errors with additional context.