Skip to content

Commit

Permalink
Merge pull request #500 from AndrewBastin/refactor/strategy-proxy-han…
Browse files Browse the repository at this point in the history
…dling

Refactoring proxy handling to be done in strategies
  • Loading branch information
AndrewBastin committed Jan 18, 2020
2 parents 5206aee + aa056ff commit 7728231
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 21 deletions.
5 changes: 0 additions & 5 deletions functions/network.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import AxiosStrategy from "./strategies/AxiosStrategy";
import ProxyStrategy from "./strategies/ProxyStrategy";
import FirefoxStrategy from "./strategies/FirefoxStrategy";


Expand All @@ -10,10 +9,6 @@ const runAppropriateStrategy = (req, store) => {
return FirefoxStrategy(req, store);
}

if (store.state.postwoman.settings.PROXY_ENABLED) {
return ProxyStrategy(req, store);
}

return AxiosStrategy(req, store);
}

Expand Down
18 changes: 17 additions & 1 deletion functions/strategies/AxiosStrategy.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,24 @@
import axios from "axios";

const axiosStrategy = async (req, _store) => {
const axiosWithProxy = async (req, store) => {
const { data } = await axios.post(
store.state.postwoman.settings.PROXY_URL ||
"https://postwoman.apollotv.xyz/",
req
);
return data;
}

const axiosWithoutProxy = async (req, _store) => {
const res = await axios(req);
return res;
};

const axiosStrategy = (req, store) => {
if (store.state.postwoman.settings.PROXY_ENABLED) {
return axiosWithProxy(req, store);
}
return axiosWithoutProxy(req, store);
}

export default axiosStrategy;
36 changes: 33 additions & 3 deletions functions/strategies/FirefoxStrategy.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,45 @@
const firefoxStrategy = (req, _store) => new Promise((resolve, reject) => {

const firefoxWithProxy = (req, store) => new Promise((resolve, reject) => {
const eventListener = (event) => {
window.removeEventListener("firefoxExtSendRequestComplete", event);

if (event.detail.error) {
reject(JSON.parse(event.detail.error));
} else {
resolve(JSON.parse(event.detail.response));
}
};

window.addEventListener("firefoxExtSendRequestComplete", eventListener);

window.firefoxExtSendRequest({
method: "post",
url: store.state.postwoman.settings.PROXY_URL || "https://postwoman.apollotv.xyz/",
data: req
});
});

const firefoxWithoutProxy = (req, _store) => new Promise((resolve, reject) => {
const eventListener = (event) => {
window.removeEventListener("firefoxExtSendRequestComplete", eventListener);

if (event.detail.error) reject(JSON.parse(event.detail.error));
else resolve(JSON.parse(event.detail.response));
if (event.detail.error) {
reject(JSON.parse(event.detail.error));
} else {
resolve(JSON.parse(event.detail.response));
}
};

window.addEventListener("firefoxExtSendRequestComplete", eventListener);

window.firefoxExtSendRequest(req);
});

const firefoxStrategy = (req, store) => {
if (store.state.postwoman.settings.PROXY_ENABLED) {
return firefoxWithProxy(req, store);
}
return firefoxWithoutProxy(req, store);
}

export default firefoxStrategy;
12 changes: 0 additions & 12 deletions functions/strategies/ProxyStrategy.js

This file was deleted.

0 comments on commit 7728231

Please sign in to comment.