Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring proxy handling to be done in strategies #500

Merged
merged 10 commits into from Jan 18, 2020
Merged

Refactoring proxy handling to be done in strategies #500

merged 10 commits into from Jan 18, 2020

Conversation

AndrewBastin
Copy link
Member

This PR intends to move the proxy handling code to the individual strategies along with that, this PR introduces Postwoman request proxy support for Firefox Extension powered requests.

NOTE: To test the Firefox extension code, you will have to load the extension locally. The extension that can be downloaded from the Firefox Add-on's page does not hook into localhost pages for security reasons, for more info on how to do that, visit https://github.com/AndrewBastin/postwoman-firefox

@AndrewBastin AndrewBastin added feature New feature or request core Changes regarding core concepts refactor Code refactoring labels Jan 17, 2020
@AndrewBastin AndrewBastin added this to the v2.0 milestone Jan 17, 2020
@AndrewBastin AndrewBastin self-assigned this Jan 17, 2020
@ghost
Copy link

ghost commented Jan 17, 2020 •
edited by ghost

DeepCode's analysis on #aa056f found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d3038660-3972-11ea-b1da-df51646d6421

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: d303fb90-3972-11ea-b1da-df51646d6421

liyasthomas
liyasthomas previously approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GET request in 6ms 🔥

@AndrewBastin
Copy link
Member Author

Also didn't notice till now.... Ticket No. 500 !!!!! wooo 🤣

jamesgeorge007
jamesgeorge007 requested changes Jan 18, 2020
View reviewed changes
Copy link
Member

@jamesgeorge007 jamesgeorge007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stay with this approach for the sake of consistency as well as code readability.

functions/strategies/AxiosStrategy.js Outdated Show resolved Hide resolved
functions/strategies/FirefoxStrategy.js Outdated Show resolved Hide resolved
functions/strategies/FirefoxStrategy.js Outdated Show resolved Hide resolved
@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: cfda7f60-39d2-11ea-9120-1db9a1cd0038

@AndrewBastin
Copy link
Member Author

@jamesgeorge007 check latest commits

jamesgeorge007
jamesgeorge007 requested changes Jan 18, 2020
View reviewed changes
functions/strategies/AxiosStrategy.js Outdated Show resolved Hide resolved
functions/strategies/FirefoxStrategy.js Outdated Show resolved Hide resolved
functions/strategies/FirefoxStrategy.js Outdated Show resolved Hide resolved
AndrewBastin and others added 2 commits January 18, 2020 04:22
@AndrewBastin @jamesgeorge007
Update functions/strategies/FirefoxStrategy.js
a1568a9 
Co-Authored-By: James George <jamesgeorge998001@gmail.com>
@AndrewBastin @jamesgeorge007
Update functions/strategies/AxiosStrategy.js
8e86e4c 
Co-Authored-By: James George <jamesgeorge998001@gmail.com>
@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b8edbea0-39d4-11ea-9120-1db9a1cd0038

@AndrewBastin
Copy link
Member Author

So sorry for the mess, I gotta get some sleep 😪

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 6e59af10-39d5-11ea-9120-1db9a1cd0038

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a2f45e90-39d6-11ea-9120-1db9a1cd0038

@TravisBuddy
Copy link

Hey @AndrewBastin,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 041d8a40-39da-11ea-9120-1db9a1cd0038

@AndrewBastin AndrewBastin merged commit 7728231 into hoppscotch:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesgeorge007 jamesgeorge007 jamesgeorge007 approved these changes

@liyasthomas liyasthomas Awaiting requested review from liyasthomas

Assignees

@AndrewBastin AndrewBastin

Labels
core Changes regarding core concepts feature New feature or request refactor Code refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndrewBastin @TravisBuddy @liyasthomas @jamesgeorge007