Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP request with different library #61

Closed
diego81b opened this issue Aug 25, 2019 · 5 comments · Fixed by #96
Closed

HTTP request with different library #61

diego81b opened this issue Aug 25, 2019 · 5 comments · Fixed by #96
Assignees
Labels
core Changes regarding core concepts future Scheduled to near future

Comments

@diego81b
Copy link

diego81b commented Aug 25, 2019

Is your feature request related to a problem?
No

Describe the solution you'd like
Why the need to use xhr instead, for example, Axios.
One factor should be the need to use interceptors before or after request

Describe alternatives you've considered
Any

Additional context
No

@liyasthomas liyasthomas added core Changes regarding core concepts future Scheduled to near future labels Aug 25, 2019
@izerozlu
Copy link
Contributor

@diego81b I suppose the main reason for this decision is to keep the application as light as possible.
But in my opinion, it'd be easier to maintain the application with a proper library.

@liyasthomas
Copy link
Member

As I've mentioned in #76 we could possible use anyone from of these:

@NBTX
Copy link
Contributor

NBTX commented Aug 28, 2019

I vote axios.

@diego81b
Copy link
Author

Another solution could be use Fetch Api but is not supported on IE11 ( damn IE 😄) and do not have interceptor.
On the same way intersting will be the abort Api (they works with xhr) but it is another matter 😅

@NBTX
Copy link
Contributor

NBTX commented Aug 29, 2019

As I'm working on building a proxy to bypass the Same-Origin policy, I'm going to address this issue, as axios interceptors will make implementing the proxy much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes regarding core concepts future Scheduled to near future
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants