Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use axios for requests, UI tweaks, and more... #96

Merged
merged 5 commits into from
Aug 30, 2019
Merged

Use axios for requests, UI tweaks, and more... #96

merged 5 commits into from
Aug 30, 2019

Conversation

NBTX
Copy link
Contributor

@NBTX NBTX commented Aug 30, 2019

Test URL: https://nbtx.github.io/postwoman-vue/


image

image

  • Adds metro-style slider component and changes checkboxes to sliders.

image

  • Shows response body on error, thus allowing you to preview error pages, etc.

  • Fixes the disabled state on key events and button presses.
  • Fixes the disabled style on key events and button presses.

@NBTX NBTX added need testing Needs to be tested before merging onto production and removed need testing Needs to be tested before merging onto production labels Aug 30, 2019
@NBTX NBTX requested a review from liyasthomas August 30, 2019 00:19
@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: e150ba10-cabb-11e9-8574-4b7115d53811

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gold ✨

@liyasthomas liyasthomas merged commit f485af3 into hoppscotch:master Aug 30, 2019
@liyasthomas liyasthomas added the core Changes regarding core concepts label Aug 30, 2019
@liyasthomas
Copy link
Member

@NBTX I'm getting error on console:

Refused to set unsafe header "Content-Length"

On methods: PUT, POST, PATCH

@NBTX
Copy link
Contributor Author

NBTX commented Aug 30, 2019

Weird... weren't they set before?

@nickpalenchar
Copy link
Contributor

I'm running an older version and can confirm the same thing happens before this merge (it was set here)

It looks like this is the behavior of most browsers rather than the code.

@liyasthomas
Copy link
Member

So that' probably a browser specific bug then.

@NBTX
Copy link
Contributor Author

NBTX commented Aug 30, 2019

Perhaps we just weren't testing POST requests when we didn't notice it before because I read up that browsers block Content-Length as a security feature and it's handled for us by the browser.

@liyasthomas
Copy link
Member

Think it can be solved by proxy middleware?

@NBTX
Copy link
Contributor Author

NBTX commented Aug 30, 2019

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes regarding core concepts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP request with different library
5 participants