Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code highlighting #142

Merged
merged 5 commits into from
Sep 11, 2019
Merged

Code highlighting #142

merged 5 commits into from
Sep 11, 2019

Conversation

JacobAnavisca
Copy link
Contributor

Probably needs some updating. A bit of a hack with some of the CSS.

@JacobAnavisca JacobAnavisca mentioned this pull request Sep 10, 2019
Closed
@TravisBuddy
Copy link

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 8e2e3ed0-d384-11e9-9a2a-b93990a2c4d9

@liyasthomas liyasthomas self-requested a review September 10, 2019 04:55
@liyasthomas liyasthomas added core Changes regarding core concepts feature New feature or request need testing Needs to be tested before merging onto production labels Sep 10, 2019
@liyasthomas liyasthomas added this to the v1.0 Stable release milestone Sep 10, 2019
@TravisBuddy
Copy link

Hey @JacobAnavisca,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7fbedf20-d448-11e9-847a-07722ef8bbdd

liyasthomas
liyasthomas approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@JacobAnavisca JacobAnavisca merged commit 0ad76be into hoppscotch:master Sep 11, 2019
@liyasthomas
Copy link
Member

liyasthomas commented Sep 11, 2019 •
edited

@JacobAnavisca I stumbled upon a bug in which repeated requests response body are not updated in textarea.

To reproduce:

  1. Send a request
  2. Send another request
  3. Response body is not updated
  4. Preview HTML is also kinda broken

@JacobAnavisca
Copy link
Contributor Author

@liyasthomas Sorry for merging! I thought the OK meant good to merge. Do you have an API that returns HTML so I can test and get a fix in?

@liyasthomas
Copy link
Member

liyasthomas commented Sep 12, 2019 •
edited

All 404 returns HTML response. Ex: path: /api/user/55

@JacobAnavisca
Copy link
Contributor Author

@liyasthomas Just committed a fix for the response issue. I didn't notice an issue with the Preview HTML unless I'm missing something.

@liyasthomas
Copy link
Member

@JacobAnavisca Thanks for the quick response

@liyasthomas liyasthomas mentioned this pull request Sep 12, 2019
Closed
@liyasthomas liyasthomas mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

Assignees
No one assigned
Labels
core Changes regarding core concepts feature New feature or request need testing Needs to be tested before merging onto production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JacobAnavisca @TravisBuddy @liyasthomas