Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code highlight on response body #33

Closed
liyasthomas opened this issue Aug 23, 2019 · 7 comments
Closed

Code highlight on response body #33

liyasthomas opened this issue Aug 23, 2019 · 7 comments
Assignees
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@liyasthomas
Copy link
Member

Is your feature request related to a problem? Please describe.
Response body is displayed in plain textarea.

Describe the solution you'd like
Need code highlighting feature.

Describe alternatives you've considered
https://highlightjs.org

Additional context
Add code highlighting to not only the response body but also to parameter lists, POST request body etc.

@liyasthomas liyasthomas self-assigned this Aug 23, 2019
@liyasthomas liyasthomas added feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 23, 2019
@liyasthomas
Copy link
Member Author

@AndrewBastin can you take a look at this feature request and possibly make a PR?

@AndrewBastin
Copy link
Member

Well, I am kinda working on an implementation for this in Prism....
It is a bit hacky, but I am working on one....

If issue #31 is resolved, we can use vue-highlight to do the highlighting hopefully in a less hacky way.

PR coming hopefully tomorrow...

Meanwhile, @liyasthomas you can assign the issue to me

@AndrewBastin
Copy link
Member

AndrewBastin commented Aug 24, 2019

Well, I have kinda almost finished implementing it, just some few small stuff with like CSS issues are left there to fix, but #44 will require a full rewrite of my current implementation so I am not submitting a PR....

But anyways I have pushed the change in my fork for peeps willing to have a peek and are willing to contribute to....

I am just gonna stop working on this right now and move to other stuff...

@AndrewBastin
Copy link
Member

Sorry for the delays in finishing this, I was kinda busy with travels and stuff... I have submitted a PR #78 resolving the issue with Prism. Please look into it.

@liyasthomas liyasthomas added this to the v1.0 Stable release milestone Sep 6, 2019
@liyasthomas
Copy link
Member Author

@AndrewBastin any updates on the issue? I'm hoping to include this feature in the next version release ✨

@liyasthomas liyasthomas mentioned this issue Sep 6, 2019
@JacobAnavisca
Copy link
Contributor

Hey guys I just created a PR that uses highlight js, hope that's cool. Probably needs some updates to the CSS I added #142

@liyasthomas
Copy link
Member Author

#142 solves this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants