feat: add socket.io-client version selector menu #1867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for hoppscotch accepted. 🔨 Explore the source changes: 87c7dd7 🔍 Inspect the deploy log: https://app.netlify.com/sites/hoppscotch/deploys/61644e3282adb60008af77d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of socket.io-client version selector for Socket.IO connections
This fixes the compatibility issues that were occurring due to Hoppscotch running socket.io-client v4 and servers running an older version of socket.io. Reference: Compatibility chart
A dropdown menu has been added to allow the user to choose the appropriate version of socket.io-client to use when making the connection. The default value has been set to v4 as this was the only version available before this change.
Currently, only v2, v3, v4 versions of socket.io-client are available, and all these versions of the same package were installed using the aliases feature in pnpm. I'm not sure if this has added a significant overhead on the bundle size, it might be a possible caveat to this approach(We can use dynamic imports to load rarely used versions dynamically to fix this)
Demo
socketio-version-menu.mp4
Fixes #1614