Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync request params with bulk editor. #1930

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

0xc0Der
Copy link
Contributor

@0xc0Der 0xc0Der commented Nov 2, 2021

in this PR:

  • synced Parameters with bulk editor.
  • enabled clearAll button in bulk editor.

fixes issue #1928.

@netlify
Copy link

netlify bot commented Nov 2, 2021

👷 Deploy request for hoppscotch accepted.

🔨 Explore the source changes: 9138149

🔍 Inspect the deploy log: https://app.netlify.com/sites/hoppscotch/deploys/61825b5fbfacef0008455fd6

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request introduces 2 alerts when merging dec1b89 into 8651642 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@liyasthomas liyasthomas self-requested a review November 2, 2021 14:34
@liyasthomas liyasthomas added the feature New feature or request label Nov 2, 2021
@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request introduces 2 alerts when merging eef74c0 into 22ac13f - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2021

This pull request introduces 1 alert when merging 9138149 into 22ac13f - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyasthomas liyasthomas merged commit 2359680 into hoppscotch:main Nov 4, 2021
@0xc0Der 0xc0Der deleted the fix-sync-req-params branch November 10, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When l click "Bulk edit", the params l input in "key-value edit" will not be showed.
2 participants