Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CORS and Mixed-Content issue & Bug Fixes #200

Merged
merged 4 commits into from
Oct 20, 2019
Merged

Fix CORS and Mixed-Content issue & Bug Fixes #200

merged 4 commits into from
Oct 20, 2019

Conversation

NBTX
Copy link
Contributor

@NBTX NBTX commented Oct 20, 2019

This fixes the following issues:

  • Text selection color was incorrect
  • The 'send again' button glitched on page load

This also adds some finishing touches to the proxy code (closes #199)
and that in turn resolves #175 and resolves #2
(Thanks @hosseinnedaee!)

Finally, this adds the fonts to the application assets allowing
them to be cached by the service worker.

hosseinnedaee and others added 4 commits October 19, 2019 23:27
Because
- Get over of CORS and mixed content browser errors
This fixes the following issues:
- Text selection color was incorrect
- The 'send again' button glitched on page load

This also adds some finishing touches to the proxy code (closes #199)
and that in turn resolves #175 and resolves #2

Finally, this adds the fonts to the application assets allowing
them to be cached by the service worker.
@ghost
Copy link

ghost commented Oct 20, 2019

DeepCode Report (#f83918)

DeepCode analyzed this pull request.
There are no new issues.

@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: baccca90-f2d5-11e9-a94e-c51b88d78b8d

@liyasthomas liyasthomas merged commit 4d764b6 into hoppscotch:master Oct 20, 2019
Copy link
Contributor

@hosseinnedaee hosseinnedaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @NBTX for fix the bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants