Fix CORS and mixed content issue #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because - Get over of CORS and mixed content browser errors
DeepCode Report (#395029)DeepCode analyzed this pull request. |
|
Hey @hosseinnedaee, TravisBuddy Request Identifier: 48432ae0-f2b3-11e9-8575-bb3eea981d29 |
liyasthomas
added
core
NBTX
reviewed
Oct 19, 2019
| icon: 'error' | ||
| }); | ||
| if(!this.$store.state.postwoman.settings.PROXY_ENABLED) { | ||
| this.$toast.info('Turn on the proxy', { |
There was a problem hiding this comment.
This is looking good to me, my only recommendation is that this be renamed to 'Try enabling the proxy' or words to that effect, but it's not that significant.
There was a problem hiding this comment.
How about "Switch to Proxy mode"?
There was a problem hiding this comment.
Yes - but perhaps with the question mark. The idea being to imply to the user that it's something that might help with the error.
NBTX
approved these changes
Oct 19, 2019
|
Oh- just one other issue, we need to add |
|
See #200 which includes these commits with some finishing touches and bug fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I used Nuxtjs serverMiddleware to create a proxy server and pass the requests through the proxy and get over CORS and mixed-content issue's
resolving #175 and #2