-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: import cURL on paste #2037
feat: import cURL on paste #2037
Conversation
👷 Deploy request for hoppscotch pending review. 🔨 Explore the source changes: 5672aaa |
cc: @AndrewBastin |
This pull request introduces 2 alerts and fixes 1 when merging 1bbae72 into 10586e5 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anwarulislam It's a really neat idea!
But, I am not exactly a big fan of the implementation, it would also be cool if we could preserve the line breaks as well (if the curl paste has multiple lines, it becomes a single line). in the Import Curl modal Also it would be cool if the pasted curl string doesn't appear on the URL field.
Would love your thoughts.
This pull request introduces 1 alert and fixes 1 when merging 5672aaa into 10586e5 - view on LGTM.com new alerts:
fixed alerts:
|
@AndrewBastin I've changed these things from the last review:
|
yup, can see that. reviewing it right now 🤣 |
This pull request introduces 1 alert and fixes 1 when merging af68974 into 10586e5 - view on LGTM.com new alerts:
fixed alerts:
|
Closes #
Description
I've updated the code which contains the feature: now you can copy a cURL from the network console of the browser or from anywhere and paste it to the URL field then it will automatically recognize the cURL format. And will generate the request.
Checks
Additional Information