Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ApolloTV proxy server #217

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Add the ApolloTV proxy server #217

merged 2 commits into from
Oct 25, 2019

Conversation

NBTX
Copy link
Contributor

@NBTX NBTX commented Oct 25, 2019

As discussed, this pull request changes the proxy server to ApolloTV's proxy server for postwoman (postwoman.apollotv.xyz).

The proxy server was first implemented in #199 to help mitigate CORS issues.

@NBTX NBTX requested a review from liyasthomas October 25, 2019 19:58
@ghost
Copy link

ghost commented Oct 25, 2019

DeepCode Report (#41c82e)

DeepCode analyzed this pull request.
There are no new issues.

@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 588fb720-f762-11e9-bba2-bfeb3afa92fa

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's it! Should we remove useless files.. like /proxy/index.js etc..?

@liyasthomas liyasthomas added the feature New feature or request label Oct 25, 2019
@liyasthomas liyasthomas added this to the v1.0 Stable release milestone Oct 25, 2019
@NBTX
Copy link
Contributor Author

NBTX commented Oct 25, 2019

Yeah, I'll remove those.

@liyasthomas
Copy link
Member

@NBTX
Copy link
Contributor Author

NBTX commented Oct 25, 2019

Whoops! I removed them locally but forgot to push haha.

@liyasthomas liyasthomas self-requested a review October 25, 2019 20:16
@TravisBuddy
Copy link

Hey @NBTX,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: af3b4c40-f764-11e9-bba2-bfeb3afa92fa

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@NBTX NBTX merged commit 17adfeb into hoppscotch:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants