-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add New Request
button for folder and collection
#2241
feat: add New Request
button for folder and collection
#2241
Conversation
👷 Deploy request for hoppscotch pending review.Visit the deploys page to approve it
|
e38ca80
to
48c936f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor corrections.
packages/hoppscotch-app/components/collections/graphql/AddRequest.vue
Outdated
Show resolved
Hide resolved
This pull request introduces 4 alerts when merging c70dd1d into d634828 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 3ce2e9b into d634828 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor changes required.
packages/hoppscotch-app/components/collections/graphql/AddRequest.vue
Outdated
Show resolved
Hide resolved
This pull request introduces 3 alerts when merging 60d2acb into 745b9f7 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrections needed.
Using composables (useXXX
functions) outside the context of a setup function is not a good practice.
packages/hoppscotch-app/components/collections/graphql/AddRequest.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-app/components/collections/graphql/AddRequest.vue
Outdated
Show resolved
Hide resolved
This pull request introduces 3 alerts when merging 80d1daa into 745b9f7 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💯
New Request button is now available in the kabab menu for both folders and collections in REST as well as GraphQL. It creates a new request, saves it to the store and points to it.
`New Request` uses current session Request in both REST and GraphQL instead of default request. The name for the request is also picked up from the current session instead of `Untitled Request`
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
80d1daa
to
71ece43
Compare
This pull request introduces 3 alerts when merging 71ece43 into 745b9f7 - view on LGTM.com new alerts:
|
Description
New Request button is now available in the kabab menu
for both folders and collections in REST as well as
GraphQL.
It creates a new request, saves it to the store and
points to it.
Closes #2156