Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add New Request button for folder and collection #2241

Merged

Conversation

kyteinsky
Copy link
Contributor

@kyteinsky kyteinsky commented Apr 7, 2022

Description

New Request button is now available in the kabab menu
for both folders and collections in REST as well as
GraphQL.
It creates a new request, saves it to the store and
points to it.

Closes #2156

@netlify
Copy link

netlify bot commented Apr 7, 2022

👷 Deploy request for hoppscotch pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 80d1daa

@kyteinsky kyteinsky force-pushed the feat/new-request-in-collection branch 2 times, most recently from e38ca80 to 48c936f Compare April 7, 2022 17:23
@kyteinsky kyteinsky marked this pull request as ready for review April 7, 2022 17:24
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor corrections.

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2022

This pull request introduces 4 alerts when merging c70dd1d into d634828 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2022

This pull request introduces 3 alerts when merging 3ce2e9b into d634828 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really minor changes required.

@lgtm-com
Copy link

lgtm-com bot commented Apr 12, 2022

This pull request introduces 3 alerts when merging 60d2acb into 745b9f7 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrections needed.

Using composables (useXXX functions) outside the context of a setup function is not a good practice.

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2022

This pull request introduces 3 alerts when merging 80d1daa into 745b9f7 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@AndrewBastin AndrewBastin self-requested a review April 14, 2022 10:07
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

kyteinsky and others added 8 commits April 14, 2022 15:45
  New Request button is now available in the kabab menu
  for both folders and collections in REST as well as
  GraphQL.
  It creates a new request, saves it to the store and
  points to it.
  `New Request` uses current session Request in both REST and GraphQL
  instead of default request.
  The name for the request is also picked up from the current session
  instead of `Untitled Request`
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
@AndrewBastin AndrewBastin force-pushed the feat/new-request-in-collection branch from 80d1daa to 71ece43 Compare April 14, 2022 10:15
@lgtm-com
Copy link

lgtm-com bot commented Apr 14, 2022

This pull request introduces 3 alerts when merging 71ece43 into 745b9f7 - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

@AndrewBastin AndrewBastin merged commit ff51b7e into hoppscotch:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Add 'new request' at collection level
2 participants