Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : migrate components to script setup on ts #2267

Merged

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented Apr 14, 2022

Description

Migrate button and environment components to script setup with typescript.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@netlify
Copy link

netlify bot commented Apr 14, 2022

‼️ Deploy request for hoppscotch rejected.

Name Link
🔨 Latest commit 89b8cde

@lgtm-com
Copy link

lgtm-com bot commented Apr 14, 2022

This pull request introduces 13 alerts when merging 89b8cde into ede27e0 - view on LGTM.com

new alerts:

  • 13 for Unused variable, import, function or class

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues here and there to correct. Mostly regarding TypeScript.

@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2022

This pull request introduces 13 alerts when merging ad145d6 into f1c42f2 - view on LGTM.com

new alerts:

  • 13 for Unused variable, import, function or class

Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lgtm-com
Copy link

lgtm-com bot commented Apr 17, 2022

This pull request introduces 13 alerts when merging e947f19 into f1c42f2 - view on LGTM.com

new alerts:

  • 13 for Unused variable, import, function or class

@liyasthomas liyasthomas merged commit 01acbc8 into hoppscotch:main Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants