refactor: isolate computed header calculation on effective requests #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
Co-authored-by: liyasthomas <liyascthomas@gmail.com> Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
|
This pull request introduces 3 alerts when merging c41641c into c36e421 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging 4b88481 into c36e421 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging 154dff0 into 450af98 - view on LGTM.com new alerts:
|
liyasthomas
approved these changes
May 11, 2022
|
This pull request introduces 4 alerts when merging ea82bff into 450af98 - view on LGTM.com new alerts:
|
nivedin
pushed a commit
to nivedin/hoppscotch
that referenced
this pull request
May 13, 2022
…oppscotch#2313) Co-authored-by: liyasthomas <liyascthomas@gmail.com>
liyasthomas
added a commit
that referenced
this pull request
Jun 16, 2022
…2313) Co-authored-by: liyasthomas <liyascthomas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces some refactors and UX improvements to show the headers and parameters that are added indirectly to the request. For example, when you set to Bearer Token Authorization, the Authorization header is added during the execution of the request, the goal of this PR is to refactor those calculations to be independently exposed and to have a UX for showing the user this.
Progress
Checks
Additional Information