Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extension identification improvements #2332

Merged
merged 16 commits into from
May 19, 2022
Merged

feat: extension identification improvements #2332

merged 16 commits into from
May 19, 2022

Conversation

amk-dev
Copy link
Contributor

@amk-dev amk-dev commented May 10, 2022 •
edited by liyasthomas

  • feat: add a proxy for communicating with the extension
  • feat: add proxy logic to mounted hook

Closes #2176

Description

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Requires hoppscotch/hoppscotch-extension#136 to be merged

@amk-dev amk-dev marked this pull request as ready for review May 12, 2022 11:54
@AndrewBastin AndrewBastin self-requested a review May 12, 2022 13:36
AndrewBastin
AndrewBastin requested changes May 14, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look into the given comments

packages/hoppscotch-app/helpers/strategies/ExtensionStrategy.ts Outdated Show resolved Hide resolved
packages/hoppscotch-app/layouts/default.vue Outdated Show resolved Hide resolved
packages/hoppscotch-app/types/window.d.ts Outdated Show resolved Hide resolved
packages/hoppscotch-app/newstore/HoppExtension.ts Outdated Show resolved Hide resolved
packages/hoppscotch-app/layouts/default.vue Outdated Show resolved Hide resolved
@amk-dev amk-dev requested a review from AndrewBastin May 16, 2022 19:23
@lgtm-com
Copy link

lgtm-com bot commented May 19, 2022

This pull request introduces 3 alerts and fixes 2 when merging da9ac91 into 432337b - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2022

This pull request introduces 3 alerts and fixes 2 when merging bd93d0a into 432337b - view on LGTM.com

new alerts:

  • 3 for Unused variable, import, function or class

fixed alerts:

  • 2 for Unused variable, import, function or class

AndrewBastin
AndrewBastin approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@AndrewBastin AndrewBastin merged commit 184914b into hoppscotch:main May 19, 2022
liyasthomas pushed a commit that referenced this pull request Jun 16, 2022
@amk-dev @AndrewBastin @liyasthomas
feat: extension identification improvements (#2332)
867c2ae 
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
@AndrewBastin AndrewBastin mentioned this pull request Jun 16, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewBastin AndrewBastin AndrewBastin approved these changes

Assignees

@amk-dev amk-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: browser extension not reported but it's installed
2 participants
@amk-dev @AndrewBastin