Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: segmented content-type dropdown UI #2382

Merged

Conversation

nivedin
Copy link
Member

@nivedin nivedin commented May 30, 2022

Closes #2344

Description

This PR adds a feature that segments the HTTP body content type dropdown UI based on the type of body requests to send on endpoint.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

@liyasthomas liyasthomas marked this pull request as ready for review May 30, 2022 14:51
liyasthomas
liyasthomas previously approved these changes May 30, 2022
Copy link
Member

@liyasthomas liyasthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nivedin nivedin requested a review from liyasthomas May 31, 2022 10:58
@lgtm-com
Copy link

lgtm-com bot commented May 31, 2022

This pull request introduces 1 alert and fixes 1 when merging 708616f into eb6c4f1 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Unused variable, import, function or class

@AndrewBastin AndrewBastin self-requested a review May 31, 2022 11:31
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@AndrewBastin AndrewBastin merged commit 39f72f8 into hoppscotch:main May 31, 2022
kyteinsky pushed a commit to kyteinsky/hoppscotch that referenced this pull request Jun 4, 2022
Co-authored-by: liyasthomas <liyascthomas@gmail.com>
liyasthomas added a commit that referenced this pull request Jun 16, 2022
Co-authored-by: liyasthomas <liyascthomas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Segmentation of choice about type of body requests to send on endpoint
3 participants