Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: realtime tabs as subpages #2450

Merged
merged 3 commits into from
Jun 28, 2022

Conversation

anwarulislam
Copy link
Member

@anwarulislam anwarulislam commented Jun 21, 2022

Closes #2450

Description

Subpages in realtime page added to the system. Previously we had the same URL /realtime for WebSocket, SSE, SocketIO, and MQTT. Now URL added for the individual component.

WebSocket: https://hoppscotch.io/realtime/websocket
SSE: https://hoppscotch.io/realtime/sse
SocketIO: https://hoppscotch.io/realtime/socketio
MQTT: https://hoppscotch.io/realtime/mqtt

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

@anwarulislam anwarulislam marked this pull request as ready for review June 21, 2022 08:46
@anwarulislam anwarulislam self-assigned this Jun 21, 2022
@liyasthomas liyasthomas self-requested a review June 27, 2022 14:13
@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2022

This pull request introduces 7 alerts and fixes 7 when merging 33a29ba into ca553b9 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

fixed alerts:

  • 7 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jun 27, 2022

This pull request introduces 7 alerts and fixes 7 when merging 38a306d into ca553b9 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

fixed alerts:

  • 7 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2022

This pull request introduces 7 alerts and fixes 7 when merging 908ecd7 into ca553b9 - view on LGTM.com

new alerts:

  • 7 for Unused variable, import, function or class

fixed alerts:

  • 7 for Unused variable, import, function or class

Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@AndrewBastin AndrewBastin changed the title Realtime subpages feat: realtime tabs as subpages Jun 28, 2022
@AndrewBastin AndrewBastin merged commit 07a8a37 into hoppscotch:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants