Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: find linked account from authentication error and link it #2662

Merged

Conversation

aitchnyu
Copy link
Contributor

@aitchnyu aitchnyu commented Sep 14, 2022

Description

If an account linking error happens, new logic finds out the account and links it. Dead code related to linking accounts have been deleted.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2022

This pull request introduces 3 alerts when merging 484a6b8 into 77a561b - view on LGTM.com

new alerts:

  • 3 for Incomplete URL substring sanitization

@aitchnyu aitchnyu force-pushed the fix/fix-account-linking-firebase branch from 39dffb0 to f50d298 Compare October 3, 2022 16:10
Copy link
Member

@AndrewBastin AndrewBastin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@AndrewBastin AndrewBastin changed the title fix: find linked account from authentication error and linked it, removed account linking dead code fix: find linked account from authentication error and link it Oct 3, 2022
@AndrewBastin AndrewBastin merged commit 3c17a14 into hoppscotch:main Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants