New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduces ability to export single environment variables and allow CLI to accept the export format used by the app #3380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exporting of only personal environments is done we need to implement the same for team environment as well
5c20bf5
to
d8ae8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you verify if the CLI accepts the environment exported as a whole? It was throwing when I gave it a shot.
packages/hoppscotch-common/src/components/environments/my/Environment.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/components/environments/my/Environment.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/components/environments/my/Environment.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/components/environments/teams/Environment.vue
Show resolved
Hide resolved
packages/hoppscotch-common/src/components/environments/my/Environment.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/helpers/import-export/export/envToJson.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/helpers/import-export/export/envToJson.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/helpers/import-export/export/envToJson.ts
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/helpers/import-export/export/envToJson.ts
Outdated
Show resolved
Hide resolved
7101a1e
to
65656bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left a few minor comments. As discussed, let's add tests for the changes. Also, please ensure to raise a PR for the docs updates required.
packages/hoppscotch-common/src/components/environments/my/Environment.vue
Outdated
Show resolved
Hide resolved
packages/hoppscotch-common/src/components/environments/teams/Environment.vue
Outdated
Show resolved
Hide resolved
c915529
to
79609ad
Compare
Ticket
Closes HFE-203
Description
This PR introduces the following features and fixes to the
Hoppscotch App
andHoppscotch CLI
Features Added:
Hoppscotch App
Hoppscotch App
exports.Zod
package into theHoppscotch CLI
to check the validity of the formats for the Environment variables.Issues Fixes:
Hoppscotch App
to the CLI.Objectives
Note
Checks