Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃攲 Add websocket support #48

Merged
merged 1 commit into from Aug 24, 2019
Merged

馃攲 Add websocket support #48

merged 1 commit into from Aug 24, 2019

Conversation

NBTX
Copy link
Contributor

@NBTX NBTX commented Aug 24, 2019

image
This PR adds a navigation bar and a tab to the navigation for websockets.
This PR depends on the Nuxt.js PR.

image

Accessing insecure websockets over HTTPS displays an error in the log, rather than crashing.

This PR solves #40

@liyasthomas
Copy link
Member

As you may have noticed, #44 went faulty on deployment and almost broke my app. So, as a collective decision has been made to continue your contributions on migrate-nuxt branch here: https://github.com/liyasthomas/postwoman/tree/migrate-nuxt Let this PR too live on that branch. Considering, further pulls on migrate-nuxt branch. These features are very much appreciated and encouraged by community.

@liyasthomas liyasthomas added this to the v1.0 Stable release milestone Aug 24, 2019
@liyasthomas liyasthomas added feature New feature or request need testing Needs to be tested before merging onto production labels Aug 24, 2019
@NBTX NBTX changed the base branch from master to migrate-nuxt August 24, 2019 16:37
@NBTX NBTX mentioned this pull request Aug 24, 2019
@liyasthomas liyasthomas merged commit c11d562 into hoppscotch:migrate-nuxt Aug 24, 2019
AndrewBastin added a commit that referenced this pull request Apr 11, 2023
Co-authored-by: Andrew Bastin <andrewbastin.k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request need testing Needs to be tested before merging onto production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants