Migrate Postwoman to Nuxt.js (full Vue and SCSS support) #44
Conversation
NBTX
changed the title
|
Hey @NBTX, TravisBuddy Request Identifier: 6bc4c680-c61d-11e9-8aae-f1e5ed08699b |
|
Hey @NBTX, TravisBuddy Request Identifier: 6fbd29d0-c61d-11e9-8aae-f1e5ed08699b |
|
Hey @NBTX, TravisBuddy Request Identifier: ffb4d370-c61e-11e9-8aae-f1e5ed08699b |
|
Hey @NBTX, TravisBuddy Request Identifier: 02dbdd00-c61f-11e9-8aae-f1e5ed08699b |
|
Also, if you want to test this, you can just clone my fork and follow the instructions in the README. |
liyasthomas
added
feature
|
Can confirm this fixes #37.
|
|
I'll merge this after some testing |
|
Umm, this will shit up all the existing PRs... But this is something we need bad.... |
|
Hey @NBTX, TravisBuddy Request Identifier: 38fc0220-c66f-11e9-be9f-2924d72427a9 |
|
Hey @NBTX, TravisBuddy Request Identifier: 3d8dbf40-c66f-11e9-be9f-2924d72427a9 |
|
@NBTX lets do it. But i need your help on fixing #33 since @AndrewBastin said this will probably break his PR for "Code highlight on response body". Please check out his commit: AndrewBastin@73b5c6a and consider an alternative for it. |
Hey @liyasthomas, no probs, I will rework the commit for the new system, as I said, the current system is really hacky.... Not a big fan of it, it kinda comes really close to XSS exploitability than I like... |
|
@NBTX hosting onto GitHub pages is broken/missing |
|
I updated .travis.yml and build pushed to gh-pages branch but GitHub pages deployment keeps on loading spinner. I'm not with my PC right now to check what went wrong. Please do check it and inform me. Travis CI job: https://travis-ci.org/liyasthomas/postwoman |
|
Would it be worth considering temporarily reverting this PR and aae579c until Nuxt deploys have been fully figured out? Considering the app is down at the moment and all. |
|
@larouxn yeah, I think so too... we should really have been working on this in a separate branch as this aint stable yet... So, I can still work on improvements on the new system, while peeps can still use the app and these issues can be resolved |
|
I think this revert PR (#47) should do the trick. 🤞 |
|
Confirmed. We're back up. 🚀 |
|
Reverted. Sorry for the inconveniences caused. I checked locally and it worked. That's why I merged. But deployment went faulty. I'll look into it as soon as I can. |
|
@liyasthomas @NBTX can we get this merged into a separate branch titled something like 'migrate-nuxt' until we can figure out how to work out this stuff ? Helps out a ton for working on features... A small NOTE on Readme for new contributors would also be nice to let them know that we are migrating to Nuxt |
|
@AndrewBastin Will have seperate branches until everything get fixed. |
|
Another stuff to think about is the usage of the pwa plugin shipped with nuxt instead of the actual custom flow. IMHO relying on localstorage is a little bit risky the same for installation (mobile browser already manage installarion prompt without any manual trick). Nuxt behind the scene use workbox (if i remember well) that works well for many scenarios (updated version, caching resources, ecc...) My 2 cents 😉 |
|
I've used workbox on most of my projects. Workbox integrates seamlessly with PWA, service workers and all other PWA technologies. If there's a PWA plugin exclusively for out of the box support, I would like to see it implemented. |
|
https://github.com/liyasthomas/postwoman/tree/migrate-nuxt Let this PR relive on this branch. @NBTX @larouxn @AndrewBastin |
|
@diego81b Yes Nuxt uses workbox internally. |
|
Of course you should consider making another pulls. All of us would love to see this feature implemented 🔥✌️ |
|
@liyasthomas I've fixed the Travis configuration. I think the problem may have been the missing router base path configuration. (It's automatically generated during This time I've tested it - and all appears good 😄 |
|
Refer to PR #49 for the changes. |
|
Thanks for this PR, this made it a lot easier for me to understand the flow of the app :) |
I have migrated Postwoman to Nuxt.js configured with static site mode.
In this PR, I've also updated the README to reflect these changes.
This PR solves #31.
I did not use https://github.com/chrisvfritz/vue-enterprise-boilerplate, as @diego81b proposed, because it would - as he said - need to be appropriately resized. Nuxt is, at least in my opinion, better in this respect as it is far more modular and allows us to just pick and choose modules we want.
Key changes are the
styles.cssfile:=> /assets/css/styles.scss(you'll also seefonts.scssthat I created specifically for adding, importing and declaring font faces.)All of the PWA code has been moved into a standalone file =>
/assets/js/pwa.js(which is used in/layouts/default.vue.)The error page is now in
/layouts/error.vueThe main application page is in
/pages/index.vue- except for the header and footer, which is in/layouts/default.vueso it'll be added to every page.Finally, the main application code has been moved from
script.jsto/pages/index.vue(I didn't really want to mess with the application JS itself all in one go.)Quick footnote: Nuxt does have support for tailwind CSS but your CSS code is tidy and when it comes to design you really seem to know what you're doing! 😃
So I did not include the Tailwind module because I personally don't think it's necessary, however if you decide you would prefer to have the module, it's easy enough to add.