Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate duplicate collections #510

Merged
merged 5 commits into from Jan 21, 2020
Merged

Conversation

jamesgeorge007
Copy link
Member

closes #509

@jamesgeorge007 jamesgeorge007 added the bug fix This fixes a bug label Jan 21, 2020
@jamesgeorge007 jamesgeorge007 added this to the v2.0 milestone Jan 21, 2020
@ghost
Copy link

ghost commented Jan 21, 2020

DeepCode's analysis on #bb973e found:

  • 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

store/postwoman.js Outdated Show resolved Hide resolved
@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: fef983c0-3c40-11ea-a732-03abe341c99a

liyasthomas
liyasthomas previously approved these changes Jan 21, 2020
@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f7711280-3c59-11ea-a732-03abe341c99a

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0aae74f0-3c5a-11ea-a732-03abe341c99a

@jamesgeorge007 jamesgeorge007 merged commit b60bc1e into master Jan 21, 2020
@jamesgeorge007 jamesgeorge007 deleted the hotfix/validate-collections branch January 21, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple collections with the same name shouldn't exist
3 participants