Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validations for edit and create collections activity #516

Merged
merged 7 commits into from Jan 23, 2020
Merged

Validations for edit and create collections activity #516

merged 7 commits into from Jan 23, 2020

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Jan 23, 2020 •
edited

closes #515
Follow up of #510

@jamesgeorge007 jamesgeorge007 added the bug fix This fixes a bug label Jan 23, 2020
@jamesgeorge007 jamesgeorge007 self-assigned this Jan 23, 2020
@ghost
Copy link

ghost commented Jan 23, 2020 •
edited by ghost

DeepCode's analysis on #7d003c found:

  • ❌ 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@jamesgeorge007 jamesgeorge007 added this to the v2.0 milestone Jan 23, 2020
@liyasthomas
Copy link
Member

Check for duplicates?

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 82ee9370-3dc0-11ea-8d60-2f6c30a51d00

@jamesgeorge007
Copy link
Member Author

Check for duplicates?

#510 has already landed which brought about validations in that regard.

@liyasthomas
Copy link
Member

liyasthomas commented Jan 23, 2020 •
edited

@jamesgeorge007 there's one edge case where user edits a collection name. Please add:

  • non-empty name check
  • name duplication check

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 640d4610-3dc3-11ea-8d60-2f6c30a51d00

@jamesgeorge007 jamesgeorge007 changed the title Makes sure newly created collection has a valid name Validations for edit and create collections activity Jan 23, 2020
@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 17f3cf00-3dc4-11ea-8d60-2f6c30a51d00

@TravisBuddy
Copy link

Hey @jamesgeorge007,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 54dc0090-3dc4-11ea-8d60-2f6c30a51d00

@jamesgeorge007 jamesgeorge007 merged commit 27585d5 into master Jan 23, 2020
@jamesgeorge007 jamesgeorge007 deleted the hotfix/validate-collections branch January 23, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyasthomas liyasthomas liyasthomas approved these changes

Assignees

@jamesgeorge007 jamesgeorge007

Labels
bug fix This fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn the user if name field was left blank while creating a new collection
3 participants
@jamesgeorge007 @liyasthomas @TravisBuddy