New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth #513

Merged

liyasthomas merged 53 commits into master from auth

Jan 23, 2020

Member

liyasthomas commented Jan 22, 2020 •

edited

Auth is ready for testing 🎉

Preview deploy: https://deploy-preview-513--postwoman.netlify.com

Flow:

"Login with" button on top-right button
Select any one-time Auth provider (Google, GitHub)
Sign-in (OAuth id)
One time Toast prompt to "Turn on sync" or Enable from "Settings page"
Manual CRUD: Home page > Sidebar > Sync

fixes #514
fixes #507
fixes #26

AndrewBastin and others added 14 commits

January 19, 2020 15:24


          Fixed proxying through the firefox extension

8ae5dbc


          🎉 Initial Auth

fb4554a


          ♻️ Lint

19a2323


          ✨ Moved inputform and feed to index

c7e5fc4


          🎨 Minor UI stylings

a852432


          ✨ Delete data

29e96dd


          ✨ Show logged in user image

8bc1df9


          ♻️ Refactor

01a890b


          ✨ Account setting on setting page

40e05a0


          ✏️ Typo

43d95a2


          Added ChromeStrategy to interact with the Postwoman Chrome Extension

a235d38


          Added Chrome Strategy as a valid network strategy

2d6d1b2


          🎉 Completed MVP

a7cd639


          Merge branch 'master' into feat/chrome-extension

56c7ec3

ghost commented Jan 22, 2020 •

edited by ghost

DeepCode's analysis on #65e9e7 found:

❌ 0 critical issues. ⚠️ 0 warnings and 2 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

liyasthomas requested review from NBTX and AndrewBastin

January 22, 2020 02:16

liyasthomas self-assigned this

liyasthomas requested a review from jamesgeorge007

January 22, 2020 02:17

liyasthomas added core bug fix feature and removed bug fix labels

liyasthomas added this to the v2.0 milestone

TravisBuddy commented Jan 22, 2020

Hey @liyasthomas,
Your changes look good to me!

TravisBuddy Request Identifier: b9f53890-3cbe-11ea-b9f2-e91196c7ff19


          ⚡ Updated Firestore data rules

bf68673

TravisBuddy commented Jan 22, 2020

Hey @liyasthomas,
Your changes look good to me!

TravisBuddy Request Identifier: d6a202a0-3ccf-11ea-a40f-45b7f519932b


          🐛 Fixed sync toast prompt

a556e6d

TravisBuddy commented Jan 22, 2020

Hey @liyasthomas,
Your changes look good to me!

TravisBuddy Request Identifier: f049f980-3cd2-11ea-a40f-45b7f519932b


          🐛 Fixed broken responsiveness UI in Feeds

ea7feee

liyasthomas mentioned this pull request

Support S3 as saving/sharing collections backend-storage #514

Closed

jamesgeorge007 and others added 22 commits

January 23, 2020 14:52


          chore: validate edit collection activity for empty names

b0c22a2


          chore: validate edit collection activity for duplicate collection

f132de8


          chore: rephrase warning message

7d003ce


          Merge pull request #516 from liyasthomas/hotfix/validate-collections

27585d5

Validations for edit and create collections activity


          🎉 Initial Auth

87be0b3


          ♻️ Lint

67bcf91


          ✨ Moved inputform and feed to index


          🎨 Minor UI stylings

f89f276


          ✨ Delete data

05fe9dc


          ✨ Show logged in user image

94d0bf5


          ♻️ Refactor

1fdde89


          ✨ Account setting on setting page

211dfa2


          ✏️ Typo

b4a7c45


          🎉 Completed MVP

65e1221


          ⚡ Updated Firestore data rules

c8568ae


          🐛 Fixed sync toast prompt

b450cd7


          🐛 Fixed broken responsiveness UI in Feeds

6eb9ae8


          🐛 Fixed error on Download feed

6bcd532


          ♻️ Rewrote all DB structure

118a7aa


          🔥 Firestore rules

7275e80


          Merge branch 'auth' of https://github.com/liyasthomas/postwoman into …

2efc549

…auth


          Merged master branch

ab336de

TravisBuddy commented Jan 23, 2020

Hey @liyasthomas,
Your changes look good to me!

TravisBuddy Request Identifier: 5d28ebc0-3dd6-11ea-8d60-2f6c30a51d00


          ✨ Added History sync

65e9e7a

TravisBuddy commented Jan 23, 2020

Hey @liyasthomas,
Your changes look good to me!

TravisBuddy Request Identifier: 5c5cd970-3de7-11ea-8d60-2f6c30a51d00

liyasthomas marked this pull request as ready for review

January 23, 2020 14:28

liyasthomas merged commit 282f3c4 into master

liyasthomas deleted the auth branch

January 23, 2020 14:28

Member Author

liyasthomas commented Feb 7, 2020

wow great work liyas!
you did a wonderful job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment