Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3s4 contract and tests with deployment #53

Merged
merged 8 commits into from
Apr 25, 2022
Merged

S3s4 contract and tests with deployment #53

merged 8 commits into from
Apr 25, 2022

Conversation

QYuQianchen
Copy link
Contributor

@QYuQianchen QYuQianchen commented Apr 21, 2022 •
edited

This was referenced Apr 21, 2022
Closed
Merged
@QYuQianchen
Copy link
Contributor Author

BTW, contracts are not verified. I'd suggest to only verify them after internal audit.

@tolbrino tolbrino added the enhancement New feature or request label Apr 25, 2022
tolbrino
tolbrino requested changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@tolbrino tolbrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments apply to s4 contract.

contracts/HoprStakeSeason3.sol Outdated Show resolved Hide resolved
contracts/HoprStakeSeason3.sol Outdated Show resolved Hide resolved
tolbrino
tolbrino requested changes Apr 25, 2022
View reviewed changes
hardhat.config.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
@QYuQianchen QYuQianchen merged commit 52f16ef into main Apr 25, 2022
@QYuQianchen QYuQianchen deleted the feature/s3-s4 branch April 25, 2022 11:57
@QYuQianchen
Copy link
Contributor Author

Subgraphs for S3 and S4 are created.
See dashboards at

APIs

This was referenced Apr 25, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolbrino tolbrino tolbrino approved these changes

@SCBuergel SCBuergel Awaiting requested review from SCBuergel

@nionis nionis Awaiting requested review from nionis

Assignees

@QYuQianchen QYuQianchen

Labels
enhancement New feature or request
Projects
No open projects
CORE Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove require in _claim - RIP ☠️ Update HOPR Staking Contract for Seasons 3 and 4
2 participants
@QYuQianchen @tolbrino