This repository has been archived by the owner on Jan 14, 2024. It is now read-only.
Implement client side support for private XML storage and bookmarks. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this is intended as a development tool, to determine which non standard extensions of XEP-0048 roam in the wild. * it will break when the bookmark subpackage will be loaded (since then "storage:bookmarks" will be registered_payload in a private XML query.
horazont
approved these changes
Apr 8, 2017
| .. note:: Some other clients extend the bookmark format. For now | ||
| those extensions are silently dropped by our XSOs, and | ||
| therefore are lost, when changing the bookmarks with | ||
| aioxmpp. This is considered a bug to be fixed in the future. |
There was a problem hiding this comment.
Open an issue for it so that we don’t forget about that :-)
There was a problem hiding this comment.
Issue created: #89.
| try: | ||
| (_, (arg,), kwargs), = mock_send.mock_calls | ||
| except ValueError: | ||
| self.fail("send called with wrong signature") |
There was a problem hiding this comment.
FWIW, I don’t consider that check needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #50 and #48.
Note: The design of the bookmark service was reworked to be radically simple. It is out of scope for aioxmpp to solve the subtle issues when modifying bookmarks. However, groundwork has been laid
and explained in the documentation: The XSOs representing bookmarks have a definition of equality, this allows the use of by value list operations to modify Storage.bookmarks.