Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract content out of signed message when does the signature verific… #218

Closed
wants to merge 4 commits into from
Closed

Conversation

hnategh
Copy link
Contributor

@hnategh hnategh commented Apr 7, 2017

…ation

As the php openssl extension supports content extraction from signed message, I thought it would be very handy to fetch content after verification and add it to the result object. I know there's a extractSignedContents within this class which does quite the same thing, but since that function requires binary openssl, it would not be an option for those who want to use only openssl extension.

@yunosh
Copy link
Member

yunosh commented Apr 17, 2017

I understand the reasoning, but it still doesn't make sense to extract the data in the verification method, especially if there is an extract method. Instead, you should rewrite the extract method to use the openssl extensions instead of the binary.

@yunosh
Copy link
Member

yunosh commented Jun 6, 2017

Do you plan to update your pull request? Do you need any help with this?

@hnategh
Copy link
Contributor Author

hnategh commented Jun 9, 2017

Hi Jan,
Thank you for your reply!
Yes, you are absolutely right and it make sense to rewrite the extractSignedContents. I reverted the previous changes and rewrote the method with openssl extensions, but since there was some indentation issue the commit I would like to close this request and open new pull request with changes.

Please have a look at #223

Thank You!

@yunosh yunosh closed this Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants