Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calendar.js - onchange execution fixed. #23

Closed
wants to merge 1 commit into from
Closed

calendar.js - onchange execution fixed. #23

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2012

...ttributes of the html selectors aren't executed. This patch fixes it.

…e attributes of the html selectors aren't executed. This patch fixes it.
@yunosh
Copy link
Member

yunosh commented Dec 17, 2012

This is not the correct approach. Instead the consumer of this library (do we speak about Horde_Form here?) needs to listen on the Horde_Calendar:select event, additionally to the onchange event.

@ghost
Copy link
Author

ghost commented Jan 9, 2013

Hi. I've check the fire method and how its used in calendar.js. I see your general point yet have a hard time implementing the fix.

Multiple execution of the same onchange code may be the biggest problem. On top of that I'm not really with you on that Horde_Form thing. There's no mentioning about that in calendar.js.

@yunosh yunosh closed this Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants