Separate multi labeled pins for better readability #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's is indeed more readable than just a single space. There are some other code paths, most notably for the "all" pin display mode, that also need to be changed to match the new style in SchematicSymbol::apply_pin_names. |
|
LGTM apart from the failing style check. |
Using MIDDLE DOT unicode code point U+B7 '·' as separator.
|
Sorry, just one more thing: How about factoring the separator out into a string constant? |
Co-authored-by: Lukas K. <carrotIndustries@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial discussion on discourse.
Currently, when showing multiple alternate pin names, they are separated by a single space on the schematics:
This is somewhat difficult to read at times and may be mistaken in some scenarios as a single label. This PR adds unicode MIDDLE DOT as a visual separator between the labels: