odb export: include mounting type atrribute of components #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there something I need to do so this can be merged? |
|
How does this show up in the valor ODB++ viewer? |
|
I went here: https://trials.sw.siemens.com/en-US/trials/valor-online-pcb-viewer This is how it appears on aisler: And without this change: |
|
I've still not heard from them, so I probably wont. Is there some other way to verify this PR? It produces output conforming to the specification here: https://odbplusplus.com//wp-content/uploads/sites/2/2021/02/odb_spec_user.pdf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some manufacturers (in particular Aisler) require component mounting information in the ODB++ output to do assembly.