Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Update BloomFilter with COutPoint hashes when mine P2WPKH output is detected #94

Closed
esen opened this issue Sep 27, 2018 · 0 comments
Closed

Update BloomFilter with COutPoint hashes when mine P2WPKH output is detected #94

esen opened this issue Sep 27, 2018 · 0 comments
Assignees
@esen
Labels
enhancement Enhancement of existing feature
Projects
BitcoinKit iOS (0.1.0)

Comments

@esen
Copy link
Member

esen commented Sep 27, 2018

Currently, our peers don't send transactions sending our native P2WPKH outputs. Because, they don't test filter against witnessdata, where matching PKH is located. Therefore, we should set COutPoint hashes of those outputs to bloom filter when we detect them.

https://groups.google.com/d/msg/bitcoinj/SJpLgjowc1I/-lOEzZOhBwAJ
@esen esen added the enhancement Enhancement of existing feature label Sep 27, 2018
@esen esen self-assigned this Sep 27, 2018
@esen esen added this to To do in BitcoinKit iOS (0.1.0) via automation Sep 27, 2018
@esen esen mentioned this issue Sep 27, 2018
Closed
esen added a commit that referenced this issue Oct 17, 2018
@esen
Blocks-First Synchronization (#86, #93, #94, #95)
c6eed8b 
- SPV nodes need to use blocks-first synchronization. Headers-First synchronization assumes that you can download blocks in parallel from several peers. But that doesn't work with SPV. This change affects lots of other changes
@esen esen mentioned this issue Nov 15, 2018
Merged
BitcoinKit iOS (0.1.0) automation moved this from To do to Done Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@esen esen

Labels
enhancement Enhancement of existing feature
Projects
No open projects
BitcoinKit iOS (0.1.0)
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@esen