HORNETQ-1575 Fix new connection establishment after failure during failover #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilover In a live-backup scenario, when live is down and backup becomes live, clients using HA Connection Factories can failover automatically. However if a client decides to create a new connection by itself (as in camel jms case) there is a chance that the new connection is pointing to the dead live and the connection won't be successful. The reason is that if the old connection is gone the backup will not get a chance to announce itself back to client so it fails on initial connection. The fix is to let CF remember the old topology and use it on any initial connection attempts.
|
@clebertsuconic Hi Clebert, can you review it? thx. |
|
@gaohoward did you run the whole testsuite on this? if you did just hit Rebase and merge yourself. My only concern is the testsuite has no regressions on this case. |
|
@clebertsuconic I've carefully run and checked the test suite and I am very sure that it won't cause any regressions. |
|
@clebertsuconic ok I'll merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a live-backup scenario, when live is down and backup becomes live, clients
using HA Connection Factories can failover automatically. However if a
client decides to create a new connection by itself (as in camel jms case)
there is a chance that the new connection is pointing to the dead live
and the connection won't be successful. The reason is that if the old
connection is gone the backup will not get a chance to announce itself
back to client so it fails on initial connection.
The fix is to let CF remember the old topology and use it on any
initial connection attempts.