ROI-color-rotation-UI #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any Questions? |
|
No questions. Thanks for your contribution. We are going to release 3.1.2 this weekend. Since we didn't create the release backlog yet, your pull request will be merged after the release of version 3.1.2. This way, potentially in 3.2.0, the credits for your work will be noticed as we will have the change in the About box done. Fauze |
brizolara
added a commit
that referenced
this pull request
Aug 21, 2018
…lors were recalculated at every mouseUp; ability to change a ROI color was lost; visibility of ROIs text labels was degraded
|
You can modify our source code as you like. |
fvpolpeta
added a commit
that referenced
this pull request
Aug 22, 2018
Fix errors of #368 (ROI color rotation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a 'roicolor' variable and its setter 'setRoiColor' into ROI class.
According to (int) roicolor, Horos/HorliX draw the color of each ROI on the Viewer.
(See issue 'ROIs': #342)
This configuration makes possible dealing with unlimited ROI colors, in cotrast, OsiriX MD can deal with only 6 or 7 colors.
We are not satisfied with this modification so much because its basis depends on the OpenGL framework but Apple will make OpenGL deprecated on Mac OS X in the near future.
air-h-128k-il/H, Inomata, MD (PHAZOR, LLC)