-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove uses of deprecated torch API (removed on commit #33376 on pyto… #1731
remove uses of deprecated torch API (removed on commit #33376 on pyto… #1731
Conversation
04bff10
to
a75c319
Compare
Hey @aavbsouza, thanks for this fix! Can you rebase this change off of master? Now that #1733 has landed, we can test these changes on GPUs again. Also, as part of your PR, can you revert the most recent change to this line to unpin the torch version, like so:
That way, we can verify that these changes fix compatibility issues with the latest PyTorch nightly build. |
…rch/pytorch) Signed-off-by: aavbsouza <aavbsouza@gmail.com>
Signed-off-by: aavbsouza <aavbsouza@gmail.com>
872b44e
to
1f905bb
Compare
Signed-off-by: aavbsouza <aavbsouza@gmail.com>
Observing the results of the buildkite. First tree jobs fails, with all fails related to errors in getting the latest version of Tensorflow, for instance: ERROR: Could not find a version that satisfies the requirement tf-nightly==2.1.0.dev20191203 (from versions: none)
ERROR: No matching distribution found for tf-nightly==2.1.0.dev20191203
ERROR: Service 'test-cpu-openmpi-py2_7-tfhead-kerashead-torchhead-mxnethead-pyspark2_4_0' failed to build: The command '/bin/bash -cu pip install ${TENSORFLOW_PACKAGE}' returned a non-zero code: 1 Some time after all jobs fails without producing any output |
@aavbsouza it looks like TensorFlow may have purged some packages from pip. Instead of |
Signed-off-by: aavbsouza <aavbsouza@gmail.com>
LGTM! @romerojosh can you review as well? |
The commit pytorch/pytorch#33376 removed the functions of the family THCState_getCurrentStream. The functionality of these functions are now provided by functions of the pytorch's C10 library.
These changes causes problems on the file
read_events.cc
that use some of these functions. I have replaced these functions with the C10 correspondents. However for backward compatibility the previously used functions still on the code guarded by a TORCH_VERSION check.I have closed this same issue and I am now reopening it. Because accidentally I have messed up the signoff procedure when I first opened it. Sorry for the inconvenience
Signed-off-by: aavbsouza aavbsouza@gmail.com