Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix pytorch/mxnet build failure #245

Merged
merged 11 commits into from
Apr 29, 2020
Merged

Conversation

jasperzhong
Copy link
Contributor

  1. sudo apt-get install cuda chooses cuda-10.2 by default. cuda-10.1 has to be added explicitly.
  2. building pytorch needs c++14.
  3. python2.7 needs future to import builtins.

@jasperzhong
Copy link
Contributor Author

  1. pytorch has some updates about THCState_getCurrentStream. see remove uses of deprecated torch API (removed on commit #33376 on pyto… horovod/horovod#1731

@jasperzhong
Copy link
Contributor Author

  1. propagate exceptions from children threads to the parent thread to show failure. or CI would always pass successfully...

@bobzhuyb
Copy link
Member

Thanks for the contribution.

@pleasantrabbit Please test this PR with our internal jobs

@jasperzhong
Copy link
Contributor Author

byteps needs GPU to work but travis-ci does not have GPU instances. so only building and ps-lite can be tested. the lastest commit passes both. https://github.com/vycezhong/byteps/runs/622248551

@pleasantrabbit
Copy link
Collaborator

Thanks for the contribution.

@pleasantrabbit Please test this PR with our internal jobs

Sure. I created a test, it's been running for half an hour. Should be fine.

@bobzhuyb bobzhuyb merged commit 2bf8f2e into bytedance:master Apr 29, 2020
@bobzhuyb
Copy link
Member

@vycezhong Thanks for the contribution.

@jasperzhong jasperzhong deleted the ci branch April 29, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants