New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped support for Python 2 #1954
Conversation
Do we need to mention Python3 in docs somewhere? |
I added a mention in the Install Guide under "requirements". Might be worth it to put it somewhere on the main README, but couldn't think of a good place. |
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
I think |
Are these imports due to Python 2 compatibility?
|
Good catch, looks like these imports both work in Python 3.6 and above, so I'll update. |
Signed-off-by: Travis Addair <taddair@uber.com>
Signed-off-by: Travis Addair <taddair@uber.com>
There is one more Python2 condition in .buildkite/gen-pipeline.sh: https://github.com/horovod/horovod/blob/master/.buildkite/gen-pipeline.sh#L261. Created #1958 to fix that and some lost integration tests. |
Fixes #1929.
six
and replaced all usages with native Python 3 equivalents.