Remove and fix more Python2 conditions #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That one expression where we removed `${test} == *"py2"*` should have
been removed alltogether.
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
EnricoMi
force-pushed
the
branch-drop-python2
branch
from
0019067
to
84bb172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That one expression where we removed
${test} == *"py2"*should have been removed all together. The diff oftest/data/expected_buildkite_pipeline.yamlshowed that some unrelated Python3 tests have been removed fromgen-pipeline.shoutput: https://github.com/horovod/horovod/pull/1954/files#diff-4e74656e364613b7a60c371254085f11L760Amends #1954.
Signed-off-by: Enrico Minack github@enrico.minack.dev