Support backward_passes_per_step > 1 for TF Keras Eager Execution #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron276h
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
PR is currently failing: |
|
Hey @aaron276h, landed a fix for the Python 3.8n issue, please rebase and force push. |
Signed-off-by: aaron276h <aaron@determined.ai>
Signed-off-by: aaron276h <aaron@determined.ai>
|
Thanks @tgaddair! |
Signed-off-by: aaron276h <aaron@determined.ai>
Signed-off-by: aaron276h <aaron@determined.ai>
Unit Test Results 395 files 395 suites 2h 47m 29s ⏱️ results for commit 6a08ba9 |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: aaron276h <aaron@determined.ai>
This was referenced Oct 15, 2020
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before submitting
Description
This PR is a follow up #2346. This PR adds support for backward_passes_per_step > 1 for TF Keras optimizers executing in eager mode. This is one of the features that we have built into Determined AI's fork of Horovod that we would like to upstream.