[Ray] Use num_workers API for Horovod Ray #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
amogkam
changed the title
Signed-off-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu> Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
amogkam
force-pushed
the
ray-num-workers
branch
from
e75b08c
to
4d3c014
Compare
|
@richardliaw this is ready for review |
This comment has been minimized.
This comment has been minimized.
amogkam
force-pushed
the
ray-num-workers
branch
from
13d5230
to
33cf6e8
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Amog Kamsetty <amogkamsetty@yahoo.com>
This comment has been minimized.
This comment has been minimized.
|
Awesome work @amogkam! Is this working with the |
richardliaw
reviewed
Apr 29, 2021
horovod/ray/runner.py
Outdated
Comment on lines
189
to
198
| raise DeprecationWarning("`num_slots` is now deprecated. Please " | ||
| "use the `num_workers` API, " | ||
| "or to enforce an equal number of " | ||
| "workers on each node, set " | ||
| "`num_hosts` and `num_workers_per_host`") | ||
| if cpus_per_slot or gpus_per_slot: | ||
| raise DeprecationWarning("`cpus_per_slot` and `gpus_per_slot` " | ||
| "have been deprecated. Use " | ||
| "`cpus_per_worker` and " | ||
| "`gpus_per_worker` instead.") |
There was a problem hiding this comment.
for 1 release, can we make this a soft warning (warnings.warn) and then in the later release make this a hard warning?
This will make it much easier to enable migration,
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
|
@tgaddair yep! just added a test for that too. |
6 tasks
This comment has been minimized.
This comment has been minimized.
Unit Test Results 792 files ±0 792 suites ±0 5h 37m 0s ⏱️ ±0s For more details on these failures, see this check. Results for commit 39aa85b. ± Comparison against base commit 39aa85b. |
amogkam
added a commit
to ray-project/ray_lightning
that referenced
this pull request
Jan 6, 2022
Update to use latest Horovod-Ray API (horovod/horovod#2870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before submitting
Description
Closes #2702
Review process to land