-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not try to format tables found in code blocks #145
Conversation
Change also introduces new option, jsdocPreferCodeFences, which will format code blocks using fences (```) instead of indentation. issue: hosseinmd#144
Not sure how you'd prefer the title and message to read, since there's both a "fix:" and a "feat:". I could split it up into two PRs if you want? |
Hi dear, |
My suggestion is removing jsdocPreferCodeFences |
As suggested, I removed the new option and instead default to always fence code blocks! |
I am not sour about this change, this is a breaking change. This need more discussion. |
I'm happy to put the option to toggle whether fences or indentation are preferred back in, which would make it non-breaking. |
👍 for making it opt in if we don't want to worry about breaking changes. We should mention the option in the readme though. |
I like the code fence by default but it is a breaking change, we would need to bump the major version to not break the users workflow. This is something we can do later if we decide this is the default we really want. There's no rush to change the default right now, introducing this change under the flag sounds good to me |
All right. That was my mistake. @beark please add it to option again. Thank you. |
Change also introduces new option, jsdocPreferCodeFences, which will
format code blocks using fences (```) instead of indentation.
Fixes #144