Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ENV Variable to change the IP service used #13

Closed
Belphemur opened this issue Dec 23, 2022 · 10 comments
Closed

[Feature] ENV Variable to change the IP service used #13

Belphemur opened this issue Dec 23, 2022 · 10 comments

Comments

@Belphemur
Copy link

Belphemur commented Dec 23, 2022

Hello,

I'm having some issues where icanhazip.com don't answer the query (I'm thinking they surely block some VPN provider or have too many requests sent to them).

I've set VPN_IP_CHECK_EXIT=true to not stop the container from starting.

But it'd be nice if I could use a env var to override the service to use (like using ifconfig.co or ifconfig.me or anything else as long as it return the IP in clear text).

I'm suggesting a env var like: VPN_IP_CHECK_SERVICE that could be set to any website.

Btw, if you're interested, I can make a PR for it.

@jyggen
Copy link

jyggen commented Feb 6, 2023

Seeing this too, most of the time when the container starts icanhazip.com simply returns nothing no matter how long of a delay is added before the IP check.

@mrhotio
Copy link
Member

mrhotio commented Feb 6, 2023

I'd like to not make this a configurable option with a bunch of choices, let's just pick an alternative that works....what about dig -4 TXT +short whoami.cloudflare @1.1.1.1 ch 2>/dev/null | tr -d '"'?

@jyggen
Copy link

jyggen commented Feb 6, 2023

Works for me!

@mrhotio
Copy link
Member

mrhotio commented Feb 6, 2023

ok, test the new release

@jyggen
Copy link

jyggen commented Feb 6, 2023

The container exits with the following error message:

[ERROR] ipv6 is disabled, but we got data back in our ipv6 lookup. Exiting...

@mrhotio
Copy link
Member

mrhotio commented Feb 6, 2023

Test new update

@mrhotio mrhotio closed this as completed Feb 6, 2023
@Belphemur
Copy link
Author

@mrhotio Thanks for this, dig is definitely more reliable for this !

@mrhotio
Copy link
Member

mrhotio commented Feb 6, 2023

Not for people using mullvad it seems…might still have to tweak this.

@Nocifer
Copy link

Nocifer commented Feb 25, 2023

Hello, any word on this one getting fixed? It really does not like Mullvad, so we've been stuck on release-64adf7b for a while now :)

@mrhotio
Copy link
Member

mrhotio commented Feb 27, 2023

The check is completely removed, so it can’t cause you an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants