Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api to update the review state of submission #1350

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

Sujanadh
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Issue

Describe this PR

This PR adds new api to update the reiview states of submission integrating new function updateReviewState in osm-fieldwork. It depends on the release of osm_fieldwork package.

Response

{
  "instanceId": "uuid:5b351a25-9eec-44c0-afe8-06fb8ec38775",
  "submitterId": 51442,
  "deviceId": "collect:MPqQ2NhkGp6tsKPx",
  "createdAt": "2024-03-06T05:15:18.559Z",
  "updatedAt": "2024-03-14T05:09:41.837Z",
  "reviewState": "approved"
}

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Sujanadh Sujanadh added enhancement New feature or request Priority: Should have backend release dependent Requires update in underlying module labels Mar 14, 2024
@Sujanadh Sujanadh self-assigned this Mar 14, 2024
@Sujanadh Sujanadh marked this pull request as draft March 14, 2024 05:30
@Sujanadh
Copy link
Collaborator Author

@spwoodcock i have updated the osm-fieldwork package here in this PR , can you review it and merge?

@spwoodcock spwoodcock merged commit fb7381c into development Mar 20, 2024
5 checks passed
@spwoodcock spwoodcock deleted the feat/review-state branch March 20, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request Priority: Should have release dependent Requires update in underlying module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation Pop- up to approve or reject submissions
2 participants